Exclude comments from eldoc statement

WIP-cache
Hugo Thunnissen 9 months ago
parent 633b08809e
commit 6e5e2e3a07

@ -136,7 +136,8 @@ be implemented for return values of `phpinspect-eld-strategy-execute'")
(while (and left-sibling (while (and left-sibling
(not (phpinspect-statement-introduction-p (phpinspect-meta-token left-sibling)))) (not (phpinspect-statement-introduction-p (phpinspect-meta-token left-sibling))))
(push left-sibling statement) (unless (phpinspect-comment-p (phpinspect-meta-token left-sibling))
(push left-sibling statement))
(setq left-sibling (phpinspect-meta-find-left-sibling left-sibling))) (setq left-sibling (phpinspect-meta-find-left-sibling left-sibling)))
(phpinspect--log "Eldoc statement is: %s" (mapcar #'phpinspect-meta-token statement)) (phpinspect--log "Eldoc statement is: %s" (mapcar #'phpinspect-meta-token statement))
@ -165,16 +166,15 @@ be implemented for return values of `phpinspect-eld-strategy-execute'")
(setf (phpinspect--resolvecontext-subject rctx) (setf (phpinspect--resolvecontext-subject rctx)
(mapcar #'phpinspect-meta-token (butlast statement 2))) (mapcar #'phpinspect-meta-token (butlast statement 2)))
(let* ((type-of-previous-statement (when-let* ((type-of-previous-statement
(phpinspect-resolve-type-from-context rctx)) (phpinspect-resolve-type-from-context rctx))
(method-name-sym (phpinspect-intern-name (cadadr (phpinspect-meta-token (car match-result))))) (method-name-sym (phpinspect-intern-name (cadadr (phpinspect-meta-token (car match-result)))))
(class (phpinspect-project-get-class-create (class (phpinspect-project-get-class-create
(phpinspect--resolvecontext-project rctx) (phpinspect--resolvecontext-project rctx)
type-of-previous-statement)) type-of-previous-statement))
(method (when class (method (if static
(if static (phpinspect--class-get-static-method class method-name-sym)
(phpinspect--class-get-static-method class method-name-sym) (phpinspect--class-get-method class method-name-sym))))
(phpinspect--class-get-method class method-name-sym)))))
(when method (when method
(phpinspect-make-function-doc :fn method :arg-pos arg-pos)))) (phpinspect-make-function-doc :fn method :arg-pos arg-pos))))
((setq match-result (phpinspect--match-sequence (last statement 2) ((setq match-result (phpinspect--match-sequence (last statement 2)

Loading…
Cancel
Save