Added exceptions and fixed CS of the ZipDownloader

main
Jordi Boggiano 13 years ago
parent 99d55792f6
commit e43060eb72

@ -21,21 +21,25 @@ class ZipDownloader
{ {
public function download(PackageInterface $package, $path) public function download(PackageInterface $package, $path)
{ {
if (!class_exists('ZipArchive')) {
throw new \UnexpectedValueException('You need the zip extension enabled to use the ZipDownloader');
}
$tmpName = tempnam(sys_get_temp_dir(), ''); $tmpName = tempnam(sys_get_temp_dir(), '');
$this->downloadFile($package->getSourceUrl(), $tmpName); $this->downloadFile($package->getSourceUrl(), $tmpName);
if (!file_exists($tmpName)) { if (!file_exists($tmpName)) {
throw new \UnexpectedValueException($tmpName.' could not be created.'); throw new \UnexpectedValueException($path.' could not be saved into '.$tmpName.', make sure the'
.' directory is writable and you have internet connectivity.');
} }
$zipArchive = new ZipArchive(); $zipArchive = new ZipArchive();
if($zipArchive->open($tmpName) !== TRUE) { if (true === ($retval = $zipArchive->open($tmpName))) {
$zipArchive->extractTo($path.'/'.$package->getName()); $zipArchive->extractTo($path.'/'.$package->getName());
$zipArchive->close(); $zipArchive->close();
} } else {
else { throw new \UnexpectedValueException($tmpName.' is not a valid zip archive, got error code '.$retval);
throw new \UnexpectedValueException($tmpName.'is not a valid zip archive');
} }
} }

Loading…
Cancel
Save