Use combined assignment operators

main
Gabriel Caruso 6 years ago committed by Jordi Boggiano
parent a17f051e29
commit 71c8735e11

@ -204,7 +204,7 @@ EOT
$name = get_current_user() . '/' . $name; $name = get_current_user() . '/' . $name;
} else { } else {
// package names must be in the format foo/bar // package names must be in the format foo/bar
$name = $name . '/' . $name; $name .= '/' . $name;
} }
$name = strtolower($name); $name = strtolower($name);
} else { } else {

@ -111,7 +111,7 @@ abstract class Rule
public function enable() public function enable()
{ {
$this->bitfield = $this->bitfield & ~(255 << self::BITFIELD_DISABLED); $this->bitfield &= ~(255 << self::BITFIELD_DISABLED);
} }
public function isDisabled() public function isDisabled()

@ -269,9 +269,9 @@ class Perforce
public function generateP4Command($command, $useClient = true) public function generateP4Command($command, $useClient = true)
{ {
$p4Command = 'p4 '; $p4Command = 'p4 ';
$p4Command = $p4Command . '-u ' . $this->getUser() . ' '; $p4Command .= '-u ' . $this->getUser() . ' ';
if ($useClient) { if ($useClient) {
$p4Command = $p4Command . '-c ' . $this->getClient() . ' '; $p4Command .= '-c ' . $this->getClient() . ' ';
} }
$p4Command = $p4Command . '-p ' . $this->getPort() . ' ' . $command; $p4Command = $p4Command . '-p ' . $this->getPort() . ' ' . $command;
@ -312,7 +312,7 @@ class Perforce
chdir($this->path); chdir($this->path);
$p4SyncCommand = $this->generateP4Command('sync -f '); $p4SyncCommand = $this->generateP4Command('sync -f ');
if (null !== $sourceReference) { if (null !== $sourceReference) {
$p4SyncCommand = $p4SyncCommand . '@' . $sourceReference; $p4SyncCommand .= '@' . $sourceReference;
} }
$this->executeCommand($p4SyncCommand); $this->executeCommand($p4SyncCommand);
chdir($prevDir); chdir($prevDir);

@ -131,7 +131,7 @@ class ArchiveDownloaderTest extends TestCase
$method = new \ReflectionMethod($downloader, 'processUrl'); $method = new \ReflectionMethod($downloader, 'processUrl');
$method->setAccessible(true); $method->setAccessible(true);
$url = $url . '.' . $extension; $url .= '.' . $extension;
$expected = 'https://bitbucket.org/davereid/drush-virtualhost/get/ref.' . $extension; $expected = 'https://bitbucket.org/davereid/drush-virtualhost/get/ref.' . $extension;
$package = $this->getMockBuilder('Composer\Package\PackageInterface')->getMock(); $package = $this->getMockBuilder('Composer\Package\PackageInterface')->getMock();

Loading…
Cancel
Save