don't suggest packages already installed

main
Rob Bast 9 years ago
parent adc3e3a7f2
commit 3dffdc8705

@ -45,38 +45,54 @@ EOT
throw new \RuntimeException('Lockfile seems to be empty?'); throw new \RuntimeException('Lockfile seems to be empty?');
} }
$io = $this->getIO(); $packages = $lock['packages'];
$list = $lock['packages'];
if (!$input->getOption('no-dev')) { if (!$input->getOption('no-dev')) {
$list += $lock['packages-dev']; $packages += $lock['packages-dev'];
} }
$packages = $input->getArgument('packages'); $filter = $input->getArgument('packages');
foreach ($packages as $package) {
if (empty($package['suggest'])) {
continue;
}
foreach ($list as $package) { if (!empty($filter) && !in_array($package['name'], $filter)) {
if (!empty($package['suggest']) && (empty($packages) || in_array($package['name'], $packages))) { continue;
$this->printSuggestions($package['name'], $package['suggest']);
} }
$this->printSuggestions($packages, $package['name'], $package['suggest']);
} }
} }
protected function printSuggestions($name, $suggests) protected function printSuggestions($installed, $source, $suggestions)
{ {
$io = $this->getIO(); foreach ($suggestions as $suggestion => $reason) {
foreach ($installed as $package) {
if ($package['name'] === $suggestion) {
continue 2;
}
}
foreach ($suggests as $target => $reason) {
if (empty($reason)) { if (empty($reason)) {
$reason = '*'; $reason = '*';
} }
$this->printSuggestion($source, $suggestion, $reason);
}
}
protected function printSuggestion($package, $suggestion, $reason)
{
$io = $this->getIO();
if ($io->isVeryVerbose()) { if ($io->isVeryVerbose()) {
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>: %s', $name, $target, $reason)); $io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>: %s', $package, $suggestion, $reason));
} elseif ($io->isVerbose()) { } elseif ($io->isVerbose()) {
$io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>', $name, $target)); $io->write(sprintf('<comment>%s</comment> suggests <info>%s</info>', $package, $suggestion));
} else { } else {
$io->write(sprintf('<info>%s</info>', $target)); $io->write(sprintf('<info>%s</info>', $suggestion));
}
} }
} }
} }

Loading…
Cancel
Save