Implement storage of methods and variables

benchmarks/stubs.el

@@ -1,3 +1,26 @@
+;;; stubs.el --- Benchmarks of phpinspect stub index dump and load times  -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2023  Free Software Foundation, Inc
+
+;; Author: Hugo Thunnissen <devel@hugot.nl>
+;; Keywords: benchmark
+
+;; This program is free software; you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
 
 (require 'phpinspect-cache)
 

phpinspect-class.el

@@ -218,9 +218,7 @@ Conditionally executes BODY depending on
     (let ((existing (gethash (phpinspect--function-name-symbol method)
                              (phpinspect--class-static-methods class))))
       (if existing
-          (phpinspect--merge-method
-           (alist-get 'class-name (phpinspect--class-index class))
-           existing method extended)
+          (phpinspect--merge-method (phpinspect--class-name class) existing method extended)
         (setf (phpinspect--function--inherited method) extended)
         (phpinspect--class-set-static-method class method)))))
 
@@ -232,9 +230,7 @@ Conditionally executes BODY depending on
                               (phpinspect--class-methods class))))
 
       (if existing
-          (phpinspect--merge-method
-           (alist-get 'class-name (phpinspect--class-index class))
-           existing method extended)
+          (phpinspect--merge-method (phpinspect--class-name class) existing method extended)
         (setf (phpinspect--function--inherited method) extended)
         (phpinspect--class-set-method class method)))))
 

phpinspect-completion.el

@@ -275,38 +275,38 @@ Returns list of `phpinspect--completion'."
 
 
 (defun phpinspect-complete-at-point ()
-  (let ((comp-list (phpinspect-completion-query-execute (phpinspect--get-completion-query)))
-        strings)
-    (obarray-map (lambda (sym) (push (symbol-name sym) strings)) (phpinspect--completion-list-completions comp-list))
-    (and (phpinspect--completion-list-has-candidates comp-list)
-         (list (phpinspect--completion-list-completion-start comp-list)
-               (phpinspect--completion-list-completion-end comp-list)
-               strings
-               :affixation-function
-               (lambda (completions)
-                 (let (affixated completion)
-                   (dolist (comp completions)
-                     (setq completion (phpinspect--completion-list-get-metadata comp-list comp))
-                     (push (list comp (phpinspect--prefix-for-completion completion)
-                                 (phpinspect--completion-meta completion))
-                           affixated))
-                   (nreverse affixated)))
-               :exit-function
-               (lambda (comp-name state)
-                 (let ((comp (phpinspect--completion-list-get-metadata
-                              phpinspect--last-completion-list
-                              comp-name)))
-                 (when (and (eq 'finished state)
-                            (eq 'function (phpinspect--completion-kind comp)))
-                   (insert "(")
-                   (when (= 0 (length (phpinspect--function-arguments
-                                       (phpinspect--completion-target comp))))
-                     (insert ")")))))
-               :company-kind (lambda (comp-name)
-                               (phpinspect--completion-kind
-                                (phpinspect--completion-list-get-metadata
-                                 phpinspect--last-completion-list
-                                 comp-name)))))))
-
+  (catch 'phpinspect-parse-interrupted
+    (let ((comp-list (phpinspect-completion-query-execute (phpinspect--get-completion-query)))
+          strings)
+      (obarray-map (lambda (sym) (push (symbol-name sym) strings)) (phpinspect--completion-list-completions comp-list))
+      (and (phpinspect--completion-list-has-candidates comp-list)
+           (list (phpinspect--completion-list-completion-start comp-list)
+                 (phpinspect--completion-list-completion-end comp-list)
+                 strings
+                 :affixation-function
+                 (lambda (completions)
+                   (let (affixated completion)
+                     (dolist (comp completions)
+                       (setq completion (phpinspect--completion-list-get-metadata comp-list comp))
+                       (push (list comp (phpinspect--prefix-for-completion completion)
+                                   (phpinspect--completion-meta completion))
+                             affixated))
+                     (nreverse affixated)))
+                 :exit-function
+                 (lambda (comp-name state)
+                   (let ((comp (phpinspect--completion-list-get-metadata
+                                phpinspect--last-completion-list
+                                comp-name)))
+                     (when (and (eq 'finished state)
+                                (eq 'function (phpinspect--completion-kind comp)))
+                       (insert "(")
+                       (when (= 0 (length (phpinspect--function-arguments
+                                           (phpinspect--completion-target comp))))
+                         (insert ")")))))
+                 :company-kind (lambda (comp-name)
+                                 (phpinspect--completion-kind
+                                  (phpinspect--completion-list-get-metadata
+                                   phpinspect--last-completion-list
+                                   comp-name))))))))
 
 (provide 'phpinspect-completion)

phpinspect-index.el

@@ -60,6 +60,27 @@ of TYPE, if available."
   (or (not type)
       (phpinspect--type= type phpinspect--object-type)))
 
+(defun phpinspect--index-function-declaration (declaration type-resolver add-used-types)
+  (let (current name function-args return-type)
+    (catch 'break
+      (while (setq current (pop declaration))
+        (cond ((and (phpinspect-word-p current)
+                    (phpinspect-word-p (car declaration))
+                    (string= "function" (cadr current)))
+               (setq name (cadr (pop declaration))))
+              ((phpinspect-list-p current)
+               (setq function-args
+                     (phpinspect--index-function-arg-list
+                      type-resolver current add-used-types))
+
+               (when (setq return-type (seq-find #'phpinspect-word-p declaration))
+                 (setq return-type (funcall type-resolver
+                                            (phpinspect--make-type :name (cadr return-type)))))
+
+               (throw 'break nil)))))
+
+    (list name function-args return-type)))
+
 (defun phpinspect--index-function-from-scope (type-resolver scope comment-before &optional add-used-types namespace)
   "Index a function inside SCOPE token using phpdoc metadata in COMMENT-BEFORE.
 
@@ -69,9 +90,16 @@ function (think \"new\" statements, return types etc.)."
   (phpinspect--log "Indexing function")
   (let* ((php-func (cadr scope))
          (declaration (cadr php-func))
-         (type (if (phpinspect-word-p (car (last declaration)))
-                   (funcall type-resolver
-                            (phpinspect--make-type :name (cadar (last declaration)))))))
+         name type arguments)
+
+    (pcase-setq `(,name ,arguments ,type)
+                (phpinspect--index-function-declaration
+                 declaration type-resolver add-used-types))
+
+    ;; FIXME: Anonymous functions should not be indexed! (or if they are, they
+    ;; should at least not be visible from various UIs unless assigned to a
+    ;; variable as a closure).
+    (unless name (setq name "anonymous"))
 
     (phpinspect--log "Checking function return annotations")
 
@@ -114,12 +142,9 @@ function (think \"new\" statements, return types etc.)."
     (phpinspect--make-function
      :scope `(,(car scope))
      :token php-func
-     :name (concat (if namespace (concat namespace "\\") "") (cadadr (cdr declaration)))
+     :name (concat (if namespace (concat namespace "\\") "") name)
      :return-type (or type phpinspect--null-type)
-     :arguments (phpinspect--index-function-arg-list
-                 type-resolver
-                 (phpinspect-function-argument-list php-func)
-                 add-used-types))))
+     :arguments arguments)))
 
 (define-inline phpinspect--safe-cadr (list)
   (inline-letevals (list)

phpinspect-util.el

@@ -244,8 +244,8 @@ it evaluates to a non-nil value."
             (,match-sym (cons nil nil))
             (,match-rear-sym ,match-sym))
        (and (= ,sequence-length (length ,sequence))
-            ,@checkers)
-       (cdr ,match-sym))))
+            ,@checkers
+            (cdr ,match-sym)))))
 
 (defun phpinspect--pattern-concat (pattern1 pattern2)
   (let* ((pattern1-sequence-length (/ (length (phpinspect--pattern-code pattern1)) 2)))

phpinspect.el

@@ -224,7 +224,8 @@ Example configuration for `company-mode':
     (add-hook \\='php-mode-hook #\\='my-php-personal-hook)
 
     ;; End example configuration."
-  :after-hook (phpinspect--mode-function))
+  :after-hook (phpinspect--mode-function)
+  :keymap  (list (cons (kbd "C-c u") #'phpinspect-fix-imports)))
 
 (defun phpinspect--suggest-at-point ()
   (phpinspect--log "Entering suggest at point. Point: %d" (point))

scripts/compile.bash

@@ -1,19 +0,0 @@
-#!/bin/bash
-
-rm ./**/*.elc
-rm *.elc
-
-for file in ./*.el; do
-    echo 'Compiling '"$file"' ...'
-    cask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile "$file" || break
-done
-
-for file in ./**/*.el; do
-    echo 'Compiling '"$file"' ...'
-    cask emacs -batch -L . --eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile "$file" || break
-done
-
-if [[ -z $NO_REMOVE_ELC ]]; then
-    rm ./**/*.elc
-    rm *.elc
-fi

scripts/install-deps.el

@@ -1,4 +1,26 @@
-;;; install-deps.el --- Install dependencies -*- lexical-binding: t -*-
+;;; install-deps.el --- Install package dependencies  -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2023  Free Software Foundation, Inc
+
+;; Author: Hugo Thunnissen <devel@hugot.nl>
+;; Keywords: script
+
+;; This program is free software; you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
 
 (require 'lisp-mnt)
 

test/test-util.el

@@ -48,3 +48,10 @@
     (should (equal '(:m "a" :m * :m "b" :f stringp :m * :m "D") (phpinspect--pattern-code result)))
 
     (should (phpinspect--pattern-match result '("a" "anything" "b" "astring" nil "D")))))
+
+(ert-deftest phpinspect--pattern-match-partially ()
+  (let ((result (phpinspect--match-sequence '((:variable "this") (:object-attrib (:word "em")))
+                  :m '(:variable "this")
+                  :m '(:object-attrib (:word "not-a-match")))))
+
+    (should-not result)))