7dffe79a0f
Update tests of solver problem message to match new message
7 years ago
122e422682
CS fixes
7 years ago
4e1887a721
Improve memory usage resolving dependencies
...
It is known that composer update takes a lot of memory: #5915 , #5902 ,
I am playing with a profiler (@blackfireio) to make a demo in my local
PHP meetup (@phpvigo) and I found out a way to use less memory. These
are my first tests:
* Private project using PHP 5.6:
* Memory: from 1.31GB to 1.07GB
* Wall Time: from 2min 8s to 1min 33s
* symfony-demo using PHP 7.1 in my old mac book:
* Memory: from 667MB to 523MB
* Wall Time: from 5min 29s to 5min 28s
Not use an array inside conflict rules is this improvement main idea:
```php
<?php
//Memory 38MB
gc_collect_cycles();
gc_disable();
class Rule
{
public $literals;
public function __construct(array $literals)
{
$this->literals = $literals;
}
}
$rules = array();
$i = 0;
while ($i<80000){ //
$i++;
$array = array(-$i, $i);
$rule = new Rule($array);
$rules[] = $rule;
}
```
```php
<?php
//Memory 11.1MB
gc_collect_cycles();
gc_disable();
class Rule2Literals
{
public $literal1;
public $literal2;
public function __construct($literal1, $literal2)
{
$this->literal1 = $literal1;
$this->literal2 = $literal2;
}
}
$rules = array();
$i = 0;
while ($i<80000){ //
$i++;
$rule = new ConflictRule(-$i, $i);
$rules[] = $rule;
}
```
More info https://github.com/composer/composer/pull/6168
7 years ago
4cd6eabdba
Merge branch '1.2'
8 years ago
4a769a785c
Reduce calls on Rule::getHash()
8 years ago
9cbcda9ae6
add test that asserts pool priority matters
...
also switch assertEquals for assertSame
8 years ago
1bd9c8da3c
More ruletest fixes for 7.1
8 years ago
c74e6df65d
Fix strings being passed to an int arg, fixes 7.1 build
8 years ago
933a8e1d09
Fix method name
...
It makes the test fail with recent (>= 3.1) phpunit-mock-objects
version.
8 years ago
8e78ce9a43
Add extra logging before and after SAT solving
8 years ago
b7845bb6c0
Update SolverTest.php
9 years ago
b523fc0b7b
ran fixers
9 years ago
ce08582671
Fix CS
9 years ago
a1427d7fd6
replace all occurences in code and comments
9 years ago
6e81f63635
Reduce memory footprint of rules by storing data in blob
...
Not declaring the job property saves significant amounts of memory as
most rules leave it as null
9 years ago
b869fa9662
Correct rule hash test
9 years ago
2e99b9fdf5
Use https where possible
9 years ago
b4ed331168
The Solver Request no longer depends on the Pool
9 years ago
e0657b60a2
Fix misspellings
9 years ago
4a0feb0189
add --prefer-lowest-stable to update command
10 years ago
26598c4a9a
Remove unnecessary pool reference from rules
10 years ago
d77400ade2
Make ruleById lookup table in rule set public
...
Saves about 500k function calls on a packagist update
10 years ago
94926218e8
CS fixes
10 years ago
ec0463a400
Add tests for platform packages required by root and avoid creating rules altogether instead of disabling them, refs #3320
10 years ago
5b80144ad0
Resolve job packages after whitelist generation
11 years ago
3148ffd355
Whitelist packages with names matching those specified before generating rules
...
Addresses #2690 doesn't do any performance optimisations yet which we
could do now
11 years ago
38917c2047
Add parallel build to travis script
11 years ago
051d219438
Fix whatProvides returning too many results when no constraint is given
11 years ago
e848c76cbc
Only compare branches as versions in the policy to sort packages, but not in the solver, fixes #1817
11 years ago
cc9dac8fe2
Fix tests and convert all package lists to Name[Versions] format
11 years ago
5160dd2f5e
Return different error code for SolverProblemsException
...
To make it easier for external tools to detect SolverProblems and react
to them accordingly,
this PR introduces a new exit code.
11 years ago
b41fd35c2b
Remove unused use statement
11 years ago
0700cd9186
Adjust according to feedback
11 years ago
db4055b778
Put a higher prio on replacers of the same vendor as the required package
11 years ago
b0297ef67a
Add prefer-stable flag to pick stable package over unstable ones when possible
11 years ago
3ca22f9ef1
Fix class name
12 years ago
1c39ad779b
Fix wording
12 years ago
5d78fa6ce6
Report typos in package name if no version matches
12 years ago
beb9a5bd72
Code optimizations: avoid loops in match()
12 years ago
18492a1f84
Remove Pool::getMaxId and the solver's reliance on it
12 years ago
fb4183d5ad
Fix tests
12 years ago
d4aab7d5b6
Fix solver test
12 years ago
6573fd3f77
Add hint in solver exceptions as to what may be wrong
12 years ago
175d1939b5
Fix tests
12 years ago
e6f7150196
Change default minimum-stability to "stable", fixes #744
12 years ago
4fcc114f97
Merge pull request #808 from palex-fpt/not-equal-operator
...
Add '<>' operator to Version Parser
12 years ago
cc7632489d
Make problem report messages more readable
...
Added pretty strings to constraints
12 years ago
e130386612
Add '<>' operator for Version Parser
12 years ago
f4e9dd4fb8
Fixed PSR rules
12 years ago
a08c2a0b9f
Corrected altered error message in test
12 years ago
67fde90666
Correctly sort operations within transactions using DFS
...
Fixes #655
12 years ago
a7f1605cdf
Add test for correct sorting when force installing deps
12 years ago
26e051cb76
Decisions are now encapsulated in a separate object
12 years ago
c869566868
Make ruleHash a protected member of rules
12 years ago
dd527a4049
Remove weak rules
...
Since we no longer have suggest/recommend rules and no longer use any update
or feature rules so packages are removed by default, we do not need weak rules
anymore.
12 years ago
451bab1c2c
Get rid of Literal object / literal id mix, use literals only to save memory
12 years ago
453b9a616b
Add test for Pool handling and refactor a couple things
12 years ago
0c1944a9d0
Let the solver handle aliases instead of the installer
12 years ago
15f43571b9
Rules of type feature are no longer needed
12 years ago
c37e126e14
Installed packages are now always removed unless otherwise requested
...
This means that an update request must always be accompanied by an install
request, otherwise the package might be removed rather than updated.
12 years ago
5daeacf0ac
We won't implement choice rules, you need to edit composer.json to choose
12 years ago
f7440076fa
Revert "Merge remote-tracking branch 'naderman/remove-packages-by-default'"
...
This reverts commit 2988152602adb4188e12
12 years ago
f4d5568937
Rules of type feature are no longer needed
12 years ago
2cb2cde096
Installed packages are now always removed unless otherwise requested
...
This means that an update request must always be accompanied by an install
request, otherwise the package might be removed rather than updated.
12 years ago
0e537b9c93
We won't implement choice rules, you need to edit composer.json to choose
12 years ago
06fb1b8083
Fix priority of aliases when mixing root package aliases with branch-alias ones, fixes #576
12 years ago
a16aa68c1d
Rule literals are sorted, so first literal added is not first retrieved
...
Fixes #477
12 years ago
2c87fe5a22
Collect solver problems in Problem objects with human readable output.
12 years ago
2b08df5192
Changed repository priority in the pool
13 years ago
f3ff53b17c
Create problems directly, rather than generating impossible rules
13 years ago
dd443cd570
Complete circular dependency with alternatives through virtual packages test
13 years ago
3e1749fbad
Readd update-all jobs and make them available through the request
13 years ago
9b8e62396c
Merge pull request #324 from edorian/installNonExistingPackage
...
Create an 'impossible rule' when installing non existent packages
13 years ago
3b06a22e69
Add getVersionConstraint test case to avoid version normalization issues
13 years ago
f304a0f129
Clean up the incomplete marker like suggested in https://github.com/composer/composer/pull/324#r465391
13 years ago
1ee5d99405
When changing watched literals of a rule, update the parent's next pointer
...
The previous rule was not previously updated to point to the next rule when
removing a middle rule from the watch tree for a literal. This resulted in
jumping from one literal's watch tree to another's, which could then jump
back to the original and cause infinite loop in a case like #265 .
Fixes #265
13 years ago
e20a79ac61
Fix TODO tags to confirm with the projects standard
13 years ago
eafe13d5a5
Create an impossible rule when trying to install something that doesn't exist.
...
The rule isn't acted upon yet (hence the incomplete test) but it is there as a reminder that this case needs to be handled.
13 years ago
e6143d1584
Add todos to explain why try/catch is inside the test
13 years ago
52d876e11e
Add SolverProblemsException and test basic solver failures
13 years ago
3fb75faa75
Now that no more update rules are created the code that handles them can be removed too.
...
Also adapted the tests that used TYPE_UPDATE exemplarily to use TYPE_FEATURE.
13 years ago
a8b2db64d5
Expaned the update tests to make sure a) Only requested updates execute and b) Installed repos with no actions get pruned from the jobqueue
13 years ago
8aa0127de8
Remove test of undefined behaviour for unknown types in rulesets
13 years ago
7609f27052
Merge branch 'add-tests' of https://github.com/l3l0/composer into new-master
...
* 'add-tests' of https://github.com/l3l0/composer :
Made fixes after review.
Made changes which fied warnings and errors in tests.
Fixed tests after update and merge of changes from upstream/master
Fixed code. Changes improved code testability
Added and extended some unit tests
13 years ago
460822fb96
Fix indentation of doc comment
13 years ago
3b54316e91
Add a test for the off by one error in solver conflict resolution
13 years ago
f59ca1e2f8
Made fixes after review.
13 years ago
de7f666118
Added and extended some unit tests
13 years ago
098ba8e583
Add test
13 years ago
8cfbf9e198
Fix update, fixes #125
13 years ago
a0faa4f69f
Add a test for the complex conflict resolution fixed in #118
13 years ago
8e6f8ae57e
Add prettyVersion to packages, fixes #76
13 years ago
4140f08d9c
Use a map of installed package ids in the solver
...
The assumption package.repo == installed no longer holds for installed
packages because there are multiple wrapped installed repositories.
13 years ago
e16c3f0626
Remove useless test, packages providing different versions aren't alternatives
13 years ago
0801d8ed31
Enable solver test regarding replaced packages after policy fix
13 years ago
571c14adf9
Prefer original packages over replaced packages of same repository priority
13 years ago
1b6f57e651
Correctly implement priorities and version numbers in the default policy
13 years ago
55d5e55195
DefaultPolicy test: pick package providing newest virtual package version
13 years ago
0c30610fdc
Complete the policy tests with provider and replacement tests
13 years ago
e4c94dd415
Adding tests for the default policy specifying its desired behaviour
13 years ago
Nils Adermann
Jordi Boggiano
rubenrua
Yanick Witschi
Rob Bast
David Prévot
Niels Keurentjes
Jefferson Carpenter
Possum
isoroku
Nicolas Grekas
Robert Gruendler
Alexey Prilipko
Grégoire Pineau
Martin Hasoň
Volker Dusch
Leszek Prabucki