f5e0fc14b3
Clarify some error messages, fixes #3770
9 years ago
125dc62fab
Make trigger error visible
9 years ago
1c7016de45
remove dead code/class
9 years ago
1bf03e9621
fixed various docblocks and class properties in solver
9 years ago
b523fc0b7b
ran fixers
9 years ago
ce08582671
Fix CS
9 years ago
a1427d7fd6
replace all occurences in code and comments
9 years ago
51ef7b5eef
instead of generic be more verbose about possible causes
9 years ago
77f1d5945f
make sure php version errors are less misleading
...
* determine conflicting version in problem using pool package
* hide version in rule to keep it generic rather than possibly misleading
fixes #4319
9 years ago
cf1af58514
Use bitwise operators directly in rules instead of get/set Bitfield
9 years ago
956035e641
Remove the unnecessary return statements from setters
9 years ago
f535542fca
Use constants with names for bitfield offsets
9 years ago
329ab5cf41
Rename blob rule property to bitfield
9 years ago
961ea868ac
Use an integer bitfield for rule properties instead of a string binary blob
9 years ago
6e81f63635
Reduce memory footprint of rules by storing data in blob
...
Not declaring the job property saves significant amounts of memory as
most rules leave it as null
9 years ago
c7e1f49e78
Rule hashes are only used in the rule set, so no need to store them
9 years ago
15d572da4c
Use 4 byte integer from raw md5 instead of 5 hex representation chars
...
The hash is necessary as comparisons are significantly too slow
otherwise. The old hash function used substr on the hexadecimal
representation of the md5 hash, rather than the raw binary output. This
wastes a significant amount of memory, as each byte can only be used to
store up to 4 bit of information. The new hash has 32bit instead of
20bit and uses only a 4 byte integer instead of a 5 byte string.
9 years ago
5b1b96b61e
Output the number of rules used in the solver for profiling purposes
9 years ago
07e1d227c9
Output the size of the pool after dependency resolution for users
9 years ago
f634c6946d
Update callers of VersionParser::formatVersion()
...
Tests were moved to BasePackageTest.
9 years ago
79f9158fb2
Merge pull request #4192 from localheinz/fix/import
...
Fix: Add missing imports
9 years ago
6a64041055
CS fixes
9 years ago
12ffe2b4d4
Fix: Add missing imports
9 years ago
e184118d76
Fix: Docblock
9 years ago
75c501251d
Revert "Merge remote-tracking branch 'naderman/load-no-providers'"
...
This reverts commit 3e85f82373b025d0982b
9 years ago
3e85f82373
Merge remote-tracking branch 'naderman/load-no-providers'
9 years ago
cfd0e44312
Move private function further down in pool
9 years ago
ec5416f03c
loadDev parameter is nonsense, properly load packages in create command
9 years ago
da02c53540
Update the composer repository whatprovides test to a loadrecursively test
9 years ago
b99c03ea04
Entirely remove whatProvides from Composer repository
9 years ago
090711b21c
Completely move loading of packages from composer repo to pool
9 years ago
2e99b9fdf5
Use https where possible
9 years ago
4d0db5add6
POC Implementation of loading only explicitly named package data
9 years ago
b4ed331168
The Solver Request no longer depends on the Pool
9 years ago
d6620195e5
Prioritize repository over package versions in the default policy, fixes #3509
9 years ago
c9bdf3a07a
added the actual phpversion into the error message when phpversion doesn satisfy the requirement
9 years ago
05e08889ed
Add BC method for old usage, refs #3857
9 years ago
6b3178b169
Merge remote-tracking branch 'isoroku/fix-misspellings'
...
Conflicts:
doc/articles/handling-private-packages-with-satis.md
9 years ago
d017fa4a1d
Unused variable
9 years ago
e0657b60a2
Fix misspellings
9 years ago
3ba581f0df
Improve error messages for required hhvm/php versions, fixes #3767
9 years ago
813fd0b703
Added missing $learnedWhy property
10 years ago
4a0feb0189
add --prefer-lowest-stable to update command
10 years ago
dfe18d2e7f
Fixed dependency problem caused by pull request #3482
10 years ago
4a945da55b
Avoid generating duplicate conflict rules
...
For each version of each package we create a conflict rule with each
other version. These are then added to the rule set and skipped if
duplicate so instead we can just generate them only once to begin with
and avoid unnecessary memory allocation and duplication lookups.
10 years ago
6f41e99fe2
Add back ruleById function for BC
10 years ago
2c43a3bcd0
Improve docblocks of public properties
10 years ago
107a736440
Recreate getLiterals method for BC
10 years ago
26598c4a9a
Remove unnecessary pool reference from rules
10 years ago
d77400ade2
Make ruleById lookup table in rule set public
...
Saves about 500k function calls on a packagist update
10 years ago
5c0efdcaa2
Move public properties to top and document them
10 years ago
c6af09b1da
Make project id public
...
Reduction of rougly 1.3 million function calls on packagist update
10 years ago
ef41f136f8
Literals on rule are now public
...
This causes a reduction of ~500k function calls for packagist composer
update (~14 million total).
10 years ago
5333017aea
Remove unused selectNewestPackages method in DefaultPolicy
...
Unused as of 1b6f57e651
10 years ago
dccb728e10
Remove further unnecessary checks for packages being arrays
10 years ago
89bd9be295
This entirely removes StreamableRepositories and minimal package arrays
10 years ago
670ca2f889
Fixed issue #3441
10 years ago
83159dc153
Use elseif instead of else { if {
10 years ago
0daaa1a902
Reduce whatProvides overhead
10 years ago
ee56db8767
Remove the handling of updates in the generator
...
Updates are implicitly handled by whatProvides for install requests
10 years ago
94926218e8
CS fixes
10 years ago
ec0463a400
Add tests for platform packages required by root and avoid creating rules altogether instead of disabling them, refs #3320
10 years ago
b7fa302b90
add ignore-platform-package-requirements for update/install commands.
10 years ago
947db97e33
[ #2492 ] Removing an unused variable and use statement, fixing phpdoc
10 years ago
e6fdefb869
Update RuleWatchNode.php
10 years ago
ac497feaba
CS fixes
10 years ago
e23665be59
Fix replacers being picked if whatProvide was called before building the package whitelist, fixes #2991 , fixes #2962
10 years ago
78f2ad95a9
Correctly add decision reason to transaction
10 years ago
0e9325da79
for AliasPackages check that the aliased package is white listed so that version constraints of AliasPackages are taken into account when computing package provisions
10 years ago
aa74818fe0
Handle array candidates in whatProvides
11 years ago
eb5c785dcd
Remove superfluous string casts
11 years ago
5b80144ad0
Resolve job packages after whitelist generation
11 years ago
bc7008270f
Properly limit to name matches only if necessary
11 years ago
3148ffd355
Whitelist packages with names matching those specified before generating rules
...
Addresses #2690 doesn't do any performance optimisations yet which we
could do now
11 years ago
51e6c3a466
Optimize solving by removing packages that are excluded by the root package requires
11 years ago
0a3df27403
Remove dead code, fixes #2363
11 years ago
11a0d16ccc
CS fixes
11 years ago
cc37e4b0b8
Show defaulted version if phpversion() returns nothing, fixes #2313
11 years ago
8369624c49
Correctly set watch2 on rule watch nodes for learned rules fixes #2181
11 years ago
051d219438
Fix whatProvides returning too many results when no constraint is given
11 years ago
8d0b7f278e
CS fixes
11 years ago
6f6228fb1d
Remove unneeded use
11 years ago
b72c4cfe97
PHPDoc fix
11 years ago
831bd844bd
Almost PHPDoc problems fixed
11 years ago
7449162aa4
Report ICU failures as the intl extension being missing, refs #1939
11 years ago
e848c76cbc
Only compare branches as versions in the policy to sort packages, but not in the solver, fixes #1817
11 years ago
326faf2b51
Minor cleanups
11 years ago
faa419cc0e
Merge remote-tracking branch 'hason/alias'
11 years ago
cc9dac8fe2
Fix tests and convert all package lists to Name[Versions] format
11 years ago
201cde05be
Show reasons why an operation is executed in -vv mode, fixes #1063
11 years ago
5160dd2f5e
Return different error code for SolverProblemsException
...
To make it easier for external tools to detect SolverProblems and react
to them accordingly,
this PR introduces a new exit code.
11 years ago
0700cd9186
Adjust according to feedback
11 years ago
db4055b778
Put a higher prio on replacers of the same vendor as the required package
11 years ago
753a8345cb
Added support for the alias of an aliased package
11 years ago
a0d1d59868
Fix handling of aliases in streamable repos, fixes #1776 , fixes #1749
11 years ago
2b385cbe58
Fix dependency flags not applying to provides/replaces, fixes #1771
11 years ago
b0297ef67a
Add prefer-stable flag to pick stable package over unstable ones when possible
11 years ago
514a3cde77
CS fixes
12 years ago
da5ee6e2d7
Add warning for invalid chars in package names
12 years ago
62bf84fc4f
Rename var
12 years ago
1c39ad779b
Fix wording
12 years ago
5d78fa6ce6
Report typos in package name if no version matches
12 years ago
f18839c350
Fix var override, fixes #1061
12 years ago
83fd3967f0
Fixed PHPDoc
12 years ago
5eead93250
Fixed typos
12 years ago
125ff3e4f5
Fix root aliasing with new providers repo format
12 years ago
eceda0ffc7
Fix regression introduced in beb9a5bd72
12 years ago
5978197b5d
Reset package IDs before they can be used in the pool in case there are already some in the cache
12 years ago
6a03e4f9ac
Code optimizations: Avoiding counting repeatedly
12 years ago
beb9a5bd72
Code optimizations: avoid loops in match()
12 years ago
21a0ae9cad
Cache whatProvide calls
12 years ago
a3f9accd37
Fix various dumb issues
12 years ago
9369f48dcd
Fix package id
12 years ago
18492a1f84
Remove Pool::getMaxId and the solver's reliance on it
12 years ago
c0e5736ae7
Add support for one-file-per-provider composer repositories
12 years ago
a8171f5be0
Display prettier messages for second-degree required exts to avoid confusion
12 years ago
ded485dd60
Fix root aliasing and allow aliasing using the branch-alias as source
12 years ago
6c1820d006
Add troubleshooting URL to error message
12 years ago
6f77df296a
Speed up Pool::match for common case
12 years ago
9965f02951
Clean up link creation
12 years ago
8a275336a1
CS cleanups
12 years ago
e46d26cb9b
Add loadAliasPackage to the StreamableRepositoryInterface and clear up responsibilities between Pool and Repositories
12 years ago
9a1fd450b0
Remove code duplication
12 years ago
62ead24b61
Rename variable for clarity
12 years ago
25142c5351
Clarify variable variable usage
12 years ago
2d4076e9b2
Add support for aliases in streamed repos
12 years ago
c8a685be6b
Reduce memory usage by only loading packages that are actually needed, fixes #456
12 years ago
27d8904abe
resetToOffset method was moved to the Decisions class a while ago
12 years ago
ef637c8f1a
CS fixes
12 years ago
84dd1fc1bf
Merge pull request #898 from Seldaek/providefix
...
Fix hijacking possibility via provide bug
12 years ago
4263fe9255
Fix Solver CS
12 years ago
2f7130200a
Prevent seeing dev versions as equal when they are not, fixes #848
12 years ago
2d19cf2a00
Fix hijacking possibility via provide bug
12 years ago
6573fd3f77
Add hint in solver exceptions as to what may be wrong
12 years ago
f4409d9168
Fix problem output formatting, fixes #871
12 years ago
e6f7150196
Change default minimum-stability to "stable", fixes #744
12 years ago
f0345f0592
Aliases cannot be updated, they must be uninstalled, fixes #803
12 years ago
07a266793d
Fix invalid function call
12 years ago
698c642a9f
Deduplicate packages with a similar name/version in the error output
12 years ago
cc7632489d
Make problem report messages more readable
...
Added pretty strings to constraints
12 years ago
dc2a9bfe62
Ignore null rules in rule generator
...
Fixes #806
12 years ago
5bea5974f7
Improve error messages for solver problems
12 years ago
12abff8b4c
Simplify branch handling code
12 years ago
76f8642feb
Remove duplicate function from decisions
12 years ago
5b1a48663e
DecisionQueueFree is no longer needed
12 years ago
2fbc04b950
Make decisions countable and use foreach to iterate them in solver
12 years ago
1211d8f7d4
Correctly generate conflict and alias rules for installed packages
12 years ago
d592c0a55e
Remove only branches on right levels in revert
12 years ago
ac762ba6e9
Correctly resolve branches if necessary
12 years ago
67fde90666
Correctly sort operations within transactions using DFS
...
Fixes #655
12 years ago
26e051cb76
Decisions are now encapsulated in a separate object
12 years ago
d21032ace5
CS fixes
12 years ago
c440b4594a
More PSR-2 goodness
12 years ago
713309b38c
Show exact version being installed in create-project, fixes #724
12 years ago
16a51daac8
Fix typo in comment
12 years ago
1bd4ccbd54
php-cs-fixer magic
12 years ago
4ea9b33a6c
Merge remote-tracking branch 'naderman/solver-refactor'
12 years ago
21c7e219e2
Change "else if" to "elseif"
12 years ago
99200af51b
Correctly indent break statements
12 years ago
f193d61dfe
Remove unecessary brackets
12 years ago
7f9c5ffeef
Add documentation to RuleWatchChain and RuleWatchNode
12 years ago
76d3950992
Document the RuleWatchGraph
12 years ago
9d80a4e220
Wrong variable used for foreach. Fixes issue 674.
12 years ago
265533d390
Rename watches array to watchChains to make clearer what they are
12 years ago
e817a2e2d7
Move public members above protected members in rule watch node
12 years ago
c869566868
Make ruleHash a protected member of rules
12 years ago
fa7bd35413
Make debug solver methods protected
12 years ago
2dfea8a5e0
Only consider undecided literals for selectAndInstall
...
Fixes #707
12 years ago
dd527a4049
Remove weak rules
...
Since we no longer have suggest/recommend rules and no longer use any update
or feature rules so packages are removed by default, we do not need weak rules
anymore.
12 years ago
025581b365
Rename walkLiteral method to more explicitly say what it does
12 years ago
a395bc04d7
Get rid of continue 2; and use array_filter instead of manual looping
12 years ago
451bab1c2c
Get rid of Literal object / literal id mix, use literals only to save memory
12 years ago
9ffe0d13f5
Remove useless if
12 years ago
cdf3b4e012
Use SplDoublyLinkedList instead of custom linked list
12 years ago
731a451dfe
Move handling of watch graph to separate classes
12 years ago
71ee5c8f4c
We don't have a systemsolvable at the lowest level
12 years ago
286593cf99
Move solver debugging code into solver subclass
12 years ago
46e4ae0e6a
Move rule generation from solver into separate rule set generator
12 years ago
83c499cf29
Remove unecessary use statement in Transaction class
12 years ago
70e306f055
Process all jobs in one method and remove lock jobs which are not used
12 years ago
3fcd042fd4
Skip adding (ignored) duplicate rules which were already added
12 years ago
1d60ae1bfc
We no longer support recommended packages, remove left over code
12 years ago
92ecf5a603
Remove unused variables
12 years ago
bd66c27ff6
We mark packages as uninstallable by removing them from the repo
...
As it is faster to remove packages from the repos and keep them out of the
package pool to begin with, we don't need an installable() method on the
policy.
12 years ago
8fc09afbae
Move transaction generation to a separate class
12 years ago
5026f8a115
Fix AliasOperations output
12 years ago
453b9a616b
Add test for Pool handling and refactor a couple things
12 years ago
ef28f3b067
Basic handling of stability flags
12 years ago
66068fedcb
Add minimum-stability flag on root package to filter packages by stability
12 years ago
11c59baf59
Remove useless property in exception class
12 years ago
37d271271d
Turn assertions into solver bug exceptions with more info
12 years ago
fafd09a7ba
Improve output of operations to show details about dev versions
12 years ago
863bb59b73
Fix authorship info
12 years ago
0c1944a9d0
Let the solver handle aliases instead of the installer
12 years ago
15f43571b9
Rules of type feature are no longer needed
12 years ago
69b55f12ae
Call feature rules update rules, as there is no difference in composer
12 years ago
0bd6fa1f37
An array of installed packages is no longer needed in the solver
12 years ago
cf5d14e2e1
Move all solver members to top of the file
12 years ago
c51fedef8c
Policy rules cannot conflict with jobs anymore
...
As we no longer need special feature rules for updating installed packages
we don't have policy rules which might conflict with job rules anymore.
Everything is driven by jobs now.
12 years ago
5feff954a4
Remove commented out debug output
12 years ago
c37e126e14
Installed packages are now always removed unless otherwise requested
...
This means that an update request must always be accompanied by an install
request, otherwise the package might be removed rather than updated.
12 years ago
f4ae88a5d6
Create lookup table for installed packages in only one place
12 years ago
5daeacf0ac
We won't implement choice rules, you need to edit composer.json to choose
12 years ago
875261931c
We do not support any options to keep obsolete packages
12 years ago
f7440076fa
Revert "Merge remote-tracking branch 'naderman/remove-packages-by-default'"
...
This reverts commit 2988152602adb4188e12
12 years ago
f4d5568937
Rules of type feature are no longer needed
12 years ago
d153ab3f8f
Call feature rules update rules, as there is no difference in composer
12 years ago
f98ab2e491
An array of installed packages is no longer needed in the solver
12 years ago
7be4b82ad2
Move all solver members to top of the file
12 years ago
6410817c4e
Policy rules cannot conflict with jobs anymore
...
As we no longer need special feature rules for updating installed packages
we don't have policy rules which might conflict with job rules anymore.
Everything is driven by jobs now.
12 years ago
3618ddacb0
Remove commented out debug output
12 years ago
2cb2cde096
Installed packages are now always removed unless otherwise requested
...
This means that an update request must always be accompanied by an install
request, otherwise the package might be removed rather than updated.
12 years ago
1a48ebaf57
Create lookup table for installed packages in only one place
12 years ago
0e537b9c93
We won't implement choice rules, you need to edit composer.json to choose
12 years ago
5ba9a887c2
We do not support any options to keep obsolete packages
12 years ago
ebf78135c9
Rename method
12 years ago
06fb1b8083
Fix priority of aliases when mixing root package aliases with branch-alias ones, fixes #576
12 years ago
3f13eb87b1
fix_typo
12 years ago
53191eb0fe
Remove recommend, make suggest informational, add require-dev, fixes #78 , fixes #510
12 years ago
452c9ad24e
Merge remote-tracking branch 'naderman/remove-dontfix'
12 years ago
64a451eaf9
Remove dontFix feature for local packages and explicit fix command
...
This made sense for the libzypp, so your kernel doesn't get deleted
just cause it thinks something is broken, but it doesn't really make
sense for composer.
12 years ago
aa21b1a93a
Fix output
12 years ago
a16aa68c1d
Rule literals are sorted, so first literal added is not first retrieved
...
Fixes #477
12 years ago
5fd50080ab
Print details about missing extensions, fixes #312
12 years ago
83123b2d40
Generate human readable explanations of rules which cause problems
12 years ago
2c87fe5a22
Collect solver problems in Problem objects with human readable output.
12 years ago
9ed05e09f3
Fix version_compare for ubuntu that ships with versions like 5.3.3-1 (bigger than 5.3.3)
12 years ago
2b08df5192
Changed repository priority in the pool
13 years ago
c425b8b6cb
Prevent a package from having duplicate names
13 years ago
17f0730e51
Levels are always > 0, negative level was just a hack in the C implementation
...
Fixes #243
13 years ago
956b54e516
Use policy rule instead of stacking up another repo to prioritize aliased packages
13 years ago
f3ff53b17c
Create problems directly, rather than generating impossible rules
13 years ago
ff620afe05
Correct the parent path in the watch tree, after moving a rule out of the path
13 years ago
3e1749fbad
Readd update-all jobs and make them available through the request
13 years ago
9b8e62396c
Merge pull request #324 from edorian/installNonExistingPackage
...
Create an 'impossible rule' when installing non existent packages
13 years ago
2a92b904d2
Correct placing of braces
13 years ago
1ee5d99405
When changing watched literals of a rule, update the parent's next pointer
...
The previous rule was not previously updated to point to the next rule when
removing a middle rule from the watch tree for a literal. This resulted in
jumping from one literal's watch tree to another's, which could then jump
back to the original and cause infinite loop in a case like #265 .
Fixes #265
13 years ago
e20a79ac61
Fix TODO tags to confirm with the projects standard
13 years ago
8484199677
Display undecided literals as undecided with a ?, when printing the decision map
13 years ago
0b8fb68e93
Add a debug print method for the entire watch tree to the solver
13 years ago
eafe13d5a5
Create an impossible rule when trying to install something that doesn't exist.
...
The rule isn't acted upon yet (hence the incomplete test) but it is there as a reminder that this case needs to be handled.
13 years ago
52d876e11e
Add SolverProblemsException and test basic solver failures
13 years ago
8fd4e56029
Deciding to install a package and wanting to install it, is not a conflict
13 years ago
3fb75faa75
Now that no more update rules are created the code that handles them can be removed too.
...
Also adapted the tests that used TYPE_UPDATE exemplarily to use TYPE_FEATURE.
13 years ago
ec61297122
Remove the allowUninstall policy option and clean up the only usage
13 years ago
cbc021c05d
featureRule no longer exists, only update rule
13 years ago
5fdca19880
Removed the option to disallowed downgrades and simplifed some places where it was used
13 years ago
cc80e5a3b1
Cleanup unreachable code
13 years ago
7609f27052
Merge branch 'add-tests' of https://github.com/l3l0/composer into new-master
...
* 'add-tests' of https://github.com/l3l0/composer :
Made fixes after review.
Made changes which fied warnings and errors in tests.
Fixed tests after update and merge of changes from upstream/master
Fixed code. Changes improved code testability
Added and extended some unit tests
13 years ago
5e3bf86851
Remove .swp file
13 years ago
Jordi Boggiano
Rob Bast
Nils Adermann
Kunal Mehta
Andreas Möller
Possum
Markus Staab
Hannes Van De Vreken
isoroku
Vladimir Kartaviy
Nicolas Grekas
Steve Preston
Sam Mousa
alu
Ryan Weaver
Thai Phan
Christian Flothmann
Pavel Savinov
Robert Gruendler
Martin Hasoň
Pascal Borreli
Tim Heil
Adrien Brault
Martin Shwalbe
Nicolas Le Goff
Volker Dusch