From fc40fefa6f1cb351f13d696446ef6ffdb64f3235 Mon Sep 17 00:00:00 2001 From: Nils Adermann Date: Fri, 27 Mar 2020 23:13:21 +0100 Subject: [PATCH] Make sure nameConstraints is always set when loading a name --- src/Composer/DependencyResolver/PoolBuilder.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Composer/DependencyResolver/PoolBuilder.php b/src/Composer/DependencyResolver/PoolBuilder.php index e715c26a5..4597ec494 100644 --- a/src/Composer/DependencyResolver/PoolBuilder.php +++ b/src/Composer/DependencyResolver/PoolBuilder.php @@ -274,6 +274,8 @@ class PoolBuilder if ($request->getUpdateAllowTransitiveRootDependencies() || !$this->isRootRequire($request, $replace)) { $this->unfixPackage($request, $replace); $loadNames[$replace] = null; + // TODO should we try to merge constraints here? + $this->nameConstraints[$replace] = null; } elseif (!$request->getUpdateAllowTransitiveRootDependencies() && $this->isRootRequire($request, $replace) && !isset($this->updateAllowWarned[$require]) && $this->io) { $this->updateAllowWarned[$replace] = true; $this->io->writeError('Dependency "'.$require.'" is also a root requirement. Package has not been listed as an update argument, so keeping locked at old version. Use --with-all-dependencies to include root dependencies.');