From f8010d5220d94d26ce3a05cc191d5d0a1d8e82dc Mon Sep 17 00:00:00 2001 From: Michael Thessel Date: Wed, 20 Nov 2019 14:58:28 -0800 Subject: [PATCH] Improved hasPackage() performance --- src/Composer/Repository/ArrayRepository.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Composer/Repository/ArrayRepository.php b/src/Composer/Repository/ArrayRepository.php index 4f0409a60..815bc0087 100644 --- a/src/Composer/Repository/ArrayRepository.php +++ b/src/Composer/Repository/ArrayRepository.php @@ -28,6 +28,7 @@ class ArrayRepository extends BaseRepository { /** @var PackageInterface[] */ protected $packages; + protected $packageMap; public function __construct(array $packages = array()) { @@ -121,15 +122,13 @@ class ArrayRepository extends BaseRepository */ public function hasPackage(PackageInterface $package) { - $packageId = $package->getUniqueName(); - - foreach ($this->getPackages() as $repoPackage) { - if ($packageId === $repoPackage->getUniqueName()) { - return true; + if (empty($this->packageMap)) { + foreach ($this->getPackages() as $repoPackage) { + $this->packageMap[$repoPackage->getUniqueName()] = $repoPackage; } } - return false; + return isset($this->packageMap[$package->getUniqueName()]); } /**