From f59ca1e2f8ad847a6392db802ff95f2e7aff4e92 Mon Sep 17 00:00:00 2001 From: Leszek Prabucki Date: Mon, 23 Jan 2012 09:21:36 +0100 Subject: [PATCH] Made fixes after review. --- src/Composer/DependencyResolver/Rule.php | 2 +- .../Test/DependencyResolver/RuleSetIteratorTest.php | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Composer/DependencyResolver/Rule.php b/src/Composer/DependencyResolver/Rule.php index aab1dabab..8af24094e 100644 --- a/src/Composer/DependencyResolver/Rule.php +++ b/src/Composer/DependencyResolver/Rule.php @@ -87,7 +87,7 @@ class Rule } for ($i = 0, $n = count($this->literals); $i < $n; $i++) { - if (!($this->literals[$i]->getId() === $rule->literals[$i]->getId())) { + if ($this->literals[$i]->getId() !== $rule->literals[$i]->getId()) { return false; } } diff --git a/tests/Composer/Test/DependencyResolver/RuleSetIteratorTest.php b/tests/Composer/Test/DependencyResolver/RuleSetIteratorTest.php index d45f9a561..6340a7f68 100644 --- a/tests/Composer/Test/DependencyResolver/RuleSetIteratorTest.php +++ b/tests/Composer/Test/DependencyResolver/RuleSetIteratorTest.php @@ -39,8 +39,7 @@ class ResultSetIteratorTest extends \PHPUnit_Framework_TestCase $ruleSetIterator = new RuleSetIterator($this->rules); $result = array(); - foreach ($ruleSetIterator as $rule) - { + foreach ($ruleSetIterator as $rule) { $result[] = $rule; } @@ -58,8 +57,7 @@ class ResultSetIteratorTest extends \PHPUnit_Framework_TestCase $ruleSetIterator = new RuleSetIterator($this->rules); $result = array(); - foreach ($ruleSetIterator as $key => $rule) - { + foreach ($ruleSetIterator as $key => $rule) { $result[] = $key; }