Merge pull request #5245 from derekmarcotte/dm-fix-command-injection

fix command injection from the environment when run as root, issue #5244
main
Jordi Boggiano 8 years ago
commit efa6210f33

@ -146,7 +146,7 @@ class Application extends BaseApplication
if ($commandName !== 'self-update' && $commandName !== 'selfupdate') {
$io->writeError('<warning>Running composer as root/super user is highly discouraged as packages, plugins and scripts cannot always be trusted</warning>');
}
if ($uid = getenv('SUDO_UID')) {
if ($uid = (int) getenv('SUDO_UID')) {
// Silently clobber any sudo credentials on the invoking user to avoid privilege escalations later on
// ref. https://github.com/composer/composer/issues/5119
Silencer::call('exec', "sudo -u \\#{$uid} sudo -K > /dev/null 2>&1");

Loading…
Cancel
Save