Add lint check after phar is built

The initial 1.10.0-RC build (593b8dfb29)
had what looks like a bit flip of one > into a :, causing a parse error as $foo->bar became $foo-:bar in some class.

This is quite unpleasant and easy to miss as it requires including the file in question before the error is spotted.

It was quite lucky I ran a composer install with the new phar right after to do something else and spotted the error.

Linting all files covers this problem mostly, at least for the PHP files.
main
Jordi Boggiano 4 years ago
parent c49a81cf17
commit ee2252c6ac
No known key found for this signature in database
GPG Key ID: 7BBD42C429EC80BC

22
composer.lock generated

@ -407,16 +407,16 @@
},
{
"name": "seld/phar-utils",
"version": "1.0.2",
"version": "1.1.0",
"source": {
"type": "git",
"url": "https://github.com/Seldaek/phar-utils.git",
"reference": "84715761c35808076b00908a20317a3a8a67d17e"
"reference": "8800503d56b9867d43d9c303b9cbcc26016e82f0"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/Seldaek/phar-utils/zipball/84715761c35808076b00908a20317a3a8a67d17e",
"reference": "84715761c35808076b00908a20317a3a8a67d17e",
"url": "https://api.github.com/repos/Seldaek/phar-utils/zipball/8800503d56b9867d43d9c303b9cbcc26016e82f0",
"reference": "8800503d56b9867d43d9c303b9cbcc26016e82f0",
"shasum": ""
},
"require": {
@ -445,9 +445,9 @@
],
"description": "PHAR file format utilities, for when PHP phars you up",
"keywords": [
"phra"
"phar"
],
"time": "2020-01-13T10:41:09+00:00"
"time": "2020-02-14T15:25:33+00:00"
},
{
"name": "symfony/console",
@ -901,10 +901,6 @@
"constructor",
"instantiate"
],
"support": {
"issues": "https://github.com/doctrine/instantiator/issues",
"source": "https://github.com/doctrine/instantiator/tree/master"
},
"time": "2015-06-14T21:17:01+00:00"
},
{
@ -948,6 +944,12 @@
"license": [
"MIT"
],
"authors": [
{
"name": "Mike van Riel",
"email": "mike.vanriel@naenius.com"
}
],
"time": "2016-01-25T08:17:30+00:00"
},
{

@ -18,6 +18,7 @@ use Composer\CaBundle\CaBundle;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Process\Process;
use Seld\PharUtils\Timestamps;
use Seld\PharUtils\Linter;
/**
* The Compiler class compiles composer into a phar
@ -162,6 +163,8 @@ class Compiler
$util = new Timestamps($pharFile);
$util->updateTimestamps($this->versionDate);
$util->save($pharFile, \Phar::SHA1);
Linter::lint($pharFile);
}
/**

Loading…
Cancel
Save