From d79f2b0fd33ee9b89f3d9f1969f43dc3d570a33a Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Wed, 10 Sep 2014 16:11:05 +0100 Subject: [PATCH] Adds warning when the version field is set, fixes composer/packagist#438 --- src/Composer/Util/ConfigValidator.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Composer/Util/ConfigValidator.php b/src/Composer/Util/ConfigValidator.php index 5b33e35ae..71b0ac418 100644 --- a/src/Composer/Util/ConfigValidator.php +++ b/src/Composer/Util/ConfigValidator.php @@ -94,6 +94,10 @@ class ConfigValidator $warnings[] = 'No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.'; } + if (isset($manifest['version'])) { + $warnings[] = 'The version field is present, it is recommended to leave it out if the package is published on Packagist.'; + } + if (!empty($manifest['name']) && preg_match('{[A-Z]}', $manifest['name'])) { $suggestName = preg_replace('{(?:([a-z])([A-Z])|([A-Z])([A-Z][a-z]))}', '\\1\\3-\\2\\4', $manifest['name']); $suggestName = strtolower($suggestName);