From 80d7ab57ed215f443a03f770ea9f86fbc1fa9372 Mon Sep 17 00:00:00 2001 From: davidverholen Date: Thu, 29 Jan 2015 15:46:11 +0100 Subject: [PATCH 1/3] add check for remote Repository in GitDriver::supports --- src/Composer/Repository/Vcs/GitDriver.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Composer/Repository/Vcs/GitDriver.php b/src/Composer/Repository/Vcs/GitDriver.php index da87e2e7d..b8aa31298 100644 --- a/src/Composer/Repository/Vcs/GitDriver.php +++ b/src/Composer/Repository/Vcs/GitDriver.php @@ -241,7 +241,11 @@ class GitDriver extends VcsDriver return false; } - // TODO try to connect to the server + $process = new ProcessExecutor($io); + if($process->execute('git ls-remote ' . $url, $output) === 0) { + return true; + } + return false; } } From 50d068b977128b19b67966c4eeb002ebb4184389 Mon Sep 17 00:00:00 2001 From: davidverholen Date: Thu, 29 Jan 2015 17:08:32 +0100 Subject: [PATCH 2/3] + limit git ls-remote to heads + escape repo url --- src/Composer/Repository/Vcs/GitDriver.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Composer/Repository/Vcs/GitDriver.php b/src/Composer/Repository/Vcs/GitDriver.php index b8aa31298..298639bc0 100644 --- a/src/Composer/Repository/Vcs/GitDriver.php +++ b/src/Composer/Repository/Vcs/GitDriver.php @@ -242,7 +242,7 @@ class GitDriver extends VcsDriver } $process = new ProcessExecutor($io); - if($process->execute('git ls-remote ' . $url, $output) === 0) { + if($process->execute('git ls-remote --heads ' . ProcessExecutor::escape($url), $output) === 0) { return true; } From d650f05ddf7933a1cf6f62b6f3e4bc8a737a9872 Mon Sep 17 00:00:00 2001 From: "brandung GmbH & Co. KG" Date: Thu, 29 Jan 2015 20:00:49 +0100 Subject: [PATCH 3/3] removed needless output param --- src/Composer/Repository/Vcs/GitDriver.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Composer/Repository/Vcs/GitDriver.php b/src/Composer/Repository/Vcs/GitDriver.php index 298639bc0..807ab7294 100644 --- a/src/Composer/Repository/Vcs/GitDriver.php +++ b/src/Composer/Repository/Vcs/GitDriver.php @@ -242,7 +242,7 @@ class GitDriver extends VcsDriver } $process = new ProcessExecutor($io); - if($process->execute('git ls-remote --heads ' . ProcessExecutor::escape($url), $output) === 0) { + if($process->execute('git ls-remote --heads ' . ProcessExecutor::escape($url)) === 0) { return true; }