Solver: No need to check previous decision if we reached the first one

4 years ago · b34f916470
parent c78eb49b5e
commit b34f916470
1 changed files with 8 additions and 6 deletions
--- a/src/Composer/DependencyResolver/Solver.php
+++ b/src/Composer/DependencyResolver/Solver.php
@ -417,12 +417,14 @@ class Solver
            }
            unset($literal);

-            $decision = $this->decisions->atOffset($decisionId-1);
-            if ($rule !== $decision[Decisions::DECISION_REASON] && $decision[Decisions::DECISION_REASON] instanceof MultiConflictRule) {
-                $num++;
-                foreach ($decision[Decisions::DECISION_REASON]->getLiterals() as $literal) {
-                    if (!$this->decisions->satisfy($literal)) {
-                        $seen[abs($literal)] = true;
+            if ($decisionId > 0) {
+                $decision = $this->decisions->atOffset($decisionId-1);
+                if ($rule !== $decision[Decisions::DECISION_REASON] && $decision[Decisions::DECISION_REASON] instanceof MultiConflictRule) {
+                    $num++;
+                    foreach ($decision[Decisions::DECISION_REASON]->getLiterals() as $literal) {
+                        if (!$this->decisions->satisfy($literal)) {
+                            $seen[abs($literal)] = true;
+                        }
                    }
                }
            }