Simplified the code

12 years ago · 9e372b1d8b
parent d0faa016c1
commit 9e372b1d8b
4 changed files with 3 additions and 7 deletions
--- a/src/Composer/Installer.php
+++ b/src/Composer/Installer.php
@ -190,10 +190,6 @@ class Installer
        foreach ($this->suggestedPackages as $suggestion) {
            $target = $suggestion['target'];
            if ($installedRepo->filterPackages(function (PackageInterface $package) use ($target) {
-                // check the name first as it is the common case
-                if ($package->getName() === $target) {
-                    return false;
-                }
                if (in_array($target, $package->getNames())) {
                    return false;
                }
--- a/tests/Composer/Test/Fixtures/installer/suggest-installed.test
+++ b/tests/Composer/Test/Fixtures/installer/suggest-installed.test
@ -1,5 +1,5 @@
 --TEST--
-Suggestions are not displayed for installed packages if they are also installed
+Suggestions are not displayed for installed packages
 --COMPOSER--
 {
    "repositories": [
--- a/tests/Composer/Test/Fixtures/installer/suggest-replaced.test
+++ b/tests/Composer/Test/Fixtures/installer/suggest-replaced.test
@ -1,5 +1,5 @@
 --TEST--
-Suggestions are not displayed for installed packages if they are replaced
+Suggestions are not displayed for packages if they are replaced
 --COMPOSER--
 {
    "repositories": [
--- a/tests/Composer/Test/Fixtures/installer/suggest-uninstalled.test
+++ b/tests/Composer/Test/Fixtures/installer/suggest-uninstalled.test
@ -1,5 +1,5 @@
 --TEST--
-Suggestions are displayed for installed packages
+Suggestions are displayed
 --COMPOSER--
 {
    "repositories": [