From daf84bea33ba18afad7d69e1a02ee898f1408e2c Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 14 Oct 2016 13:38:54 +0200 Subject: [PATCH] Enhance solver perf by removing count() --- src/Composer/DependencyResolver/Solver.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Composer/DependencyResolver/Solver.php b/src/Composer/DependencyResolver/Solver.php index 934d22f0c..03bc138f2 100644 --- a/src/Composer/DependencyResolver/Solver.php +++ b/src/Composer/DependencyResolver/Solver.php @@ -758,8 +758,10 @@ class Solver $systemLevel = $level; } - for ($i = 0, $n = 0; $n < count($this->rules); $i++, $n++) { - if ($i == count($this->rules)) { + $rulesCount = count($this->rules); + + for ($i = 0, $n = 0; $n < $rulesCount; $i++, $n++) { + if ($i == $rulesCount) { $i = 0; } @@ -805,6 +807,7 @@ class Solver } // something changed, so look at all rules again + $rulesCount = count($this->rules); $n = -1; }