From 617d63f40ad3e791ffe078d4c53921b1e3abf334 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 21 Jun 2021 21:01:08 +0200 Subject: [PATCH] GH Actions: set error reporting to E_ALL Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown. --- .github/workflows/continuous-integration.yml | 2 +- .github/workflows/lint.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index daecfe22c..cfb4b4d84 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -76,7 +76,7 @@ jobs: with: coverage: "none" extensions: "intl, zip" - ini-values: "memory_limit=-1, phar.readonly=0" + ini-values: "memory_limit=-1, phar.readonly=0, error_reporting=E_ALL, display_errors=On" php-version: "${{ matrix.php-version }}" tools: composer diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0db4f34cb..befb428c2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -29,7 +29,7 @@ jobs: with: coverage: "none" extensions: "intl" - ini-values: "memory_limit=-1" + ini-values: "memory_limit=-1, error_reporting=E_ALL, display_errors=On" php-version: "${{ matrix.php-version }}" - name: "Lint PHP files"