From 471b012e3ae6ec93c5ad439c01538ffa984c5b9b Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Mon, 22 Jan 2018 13:41:32 +0100 Subject: [PATCH] Fix problem report when requiring "ext-zend opcache", refs #2509 --- src/Composer/DependencyResolver/Problem.php | 4 ++++ src/Composer/Repository/PlatformRepository.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Composer/DependencyResolver/Problem.php b/src/Composer/DependencyResolver/Problem.php index 15815be59..ba9eb9774 100644 --- a/src/Composer/DependencyResolver/Problem.php +++ b/src/Composer/DependencyResolver/Problem.php @@ -108,6 +108,10 @@ class Problem // handle php extensions if (0 === stripos($job['packageName'], 'ext-')) { + if (false !== strpos($job['packageName'], ' ')) { + return "\n - The requested PHP extension ".$job['packageName'].' should be required as '.str_replace(' ', '-', $job['packageName']).'.'; + } + $ext = substr($job['packageName'], 4); $error = extension_loaded($ext) ? 'has the wrong version ('.(phpversion($ext) ?: '0').') installed' : 'is missing from your system'; diff --git a/src/Composer/Repository/PlatformRepository.php b/src/Composer/Repository/PlatformRepository.php index 02d40e9a4..da5c9ab73 100644 --- a/src/Composer/Repository/PlatformRepository.php +++ b/src/Composer/Repository/PlatformRepository.php @@ -24,7 +24,7 @@ use Composer\Util\Silencer; */ class PlatformRepository extends ArrayRepository { - const PLATFORM_PACKAGE_REGEX = '{^(?:php(?:-64bit|-ipv6|-zts|-debug)?|hhvm|(?:ext|lib)-[^/]+)$}i'; + const PLATFORM_PACKAGE_REGEX = '{^(?:php(?:-64bit|-ipv6|-zts|-debug)?|hhvm|(?:ext|lib)-[^/ ]+)$}i'; private $versionParser;