From 2805a69e5836a583c4af0331554a4af12f978b04 Mon Sep 17 00:00:00 2001 From: Gabriel Caruso Date: Sun, 14 Oct 2018 17:48:29 -0300 Subject: [PATCH] Simplify conditions and inline temp variables --- src/Composer/Util/Perforce.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Composer/Util/Perforce.php b/src/Composer/Util/Perforce.php index c96bcb80b..d7c6816cc 100644 --- a/src/Composer/Util/Perforce.php +++ b/src/Composer/Util/Perforce.php @@ -485,8 +485,7 @@ class Perforce $resArray = explode(PHP_EOL, $result); $tags = array(); foreach ($resArray as $line) { - $index = strpos($line, 'Label'); - if (!($index === false)) { + if (strpos($line, 'Label') !== false) { $fields = explode(' ', $line); $tags[$fields[1]] = $this->getStream() . '@' . $fields[1]; } @@ -502,8 +501,7 @@ class Perforce $result = $this->commandResult; $resArray = explode(PHP_EOL, $result); foreach ($resArray as $line) { - $index = strpos($line, 'Depot'); - if (!($index === false)) { + if (strpos($line, 'Depot') !== false) { $fields = explode(' ', $line); if (strcmp($this->p4Depot, $fields[1]) === 0) { $this->p4DepotType = $fields[3];