From 0e2215dc6c40c67ca720fe4863eaff5624d8ead1 Mon Sep 17 00:00:00 2001
From: Andreas Schempp <andreas.schempp@terminal42.ch>
Date: Mon, 4 Mar 2019 11:08:59 +0100
Subject: [PATCH] Added full unit test coverage

---
 src/Composer/Util/Zip.php                     |   2 +-
 .../Composer/Test/Util/Fixtures/Zip/empty.zip | Bin 0 -> 22 bytes
 .../Test/Util/Fixtures/Zip/folder.zip         | Bin 0 -> 314 bytes
 .../Test/Util/Fixtures/Zip/multiple.zip       | Bin 0 -> 2569 bytes
 .../Test/Util/Fixtures/Zip/nojson.zip         | Bin 0 -> 134 bytes
 .../Composer/Test/Util/Fixtures/Zip/root.zip  | Bin 0 -> 194 bytes
 .../Test/Util/Fixtures/Zip/subfolder.zip      | Bin 0 -> 1328 bytes
 tests/Composer/Test/Util/ZipTest.php          | 117 ++++++++++++++++++
 8 files changed, 118 insertions(+), 1 deletion(-)
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/empty.zip
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/folder.zip
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/multiple.zip
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/nojson.zip
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/root.zip
 create mode 100644 tests/Composer/Test/Util/Fixtures/Zip/subfolder.zip
 create mode 100644 tests/Composer/Test/Util/ZipTest.php

diff --git a/src/Composer/Util/Zip.php b/src/Composer/Util/Zip.php
index 6698616ff..8c79d106c 100644
--- a/src/Composer/Util/Zip.php
+++ b/src/Composer/Util/Zip.php
@@ -13,7 +13,7 @@
 namespace Composer\Util;
 
 /**
- * @author Jordi Boggiano <j.boggiano@seld.be>
+ * @author Andreas Schempp <andreas.schempp@terminal42.ch>
  */
 class Zip
 {
diff --git a/tests/Composer/Test/Util/Fixtures/Zip/empty.zip b/tests/Composer/Test/Util/Fixtures/Zip/empty.zip
new file mode 100644
index 0000000000000000000000000000000000000000..15cb0ecb3e219d1701294bfdf0fe3f5cb5d208e7
GIT binary patch
literal 22
NcmWIWW@Tf*000g10H*)|

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/Fixtures/Zip/folder.zip b/tests/Composer/Test/Util/Fixtures/Zip/folder.zip
new file mode 100644
index 0000000000000000000000000000000000000000..72b17b542f11eaaf47e413832e50a5538eb75e9c
GIT binary patch
literal 314
zcmWIWW@h1H0D+>Q6hANnO0X~pFr?+@>xV}0Fsyl76SD${zcPw21ORo2FmM22Fq#fQ
zsE*|P+=Be#)FQpC;`}_A_B^Qe)z5+$n3nE2awkMpn|0}yKQ(`s98pqT7o`U@n4P0O
zuXwu@&;cME;LXS+%8bi#JTSL9ymbUIAx`ChI~AfE;ZS6g1sM>!moyqdb)z{OVid^P
T0p6@^AS;-FuoFnn25}ewNhC+U

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/Fixtures/Zip/multiple.zip b/tests/Composer/Test/Util/Fixtures/Zip/multiple.zip
new file mode 100644
index 0000000000000000000000000000000000000000..db8c50302d78e7512c043c4598fd62f518af151c
GIT binary patch
literal 2569
zcmWIWW@h1H0D<cfDSluElwe^HU??t4(hrT`VL0)lCT1HDe`OS52mtC3Vc-D5y=Xdk
zp*r+jg5!fr@{3YITHArz+MrtB&hYg+Y#`8jzr`aW>9J_iOYJ9Y%ed5Eum*72cZaN;
zaO1hyoCT}rHJO$_(7EzMR7prBVnNskyOY0^Ds%kJwjF24`F0_sf&IaR+?UBr$ITWk
zIBoJHw=et7;;j7DKSRxJuOFOPWPgm;YD-4jPyO)b75;*!*R2!J-G1ZSj^|&WJ^lFQ
zWsTOVpKe!P<!zZI;KcE9cEmL6oB2{s9n30k`5XI6=I6fAe^F#`>@t|$qy1u1*_P$Z
zvM=ps&z`pNhrzl%+Hq%qa`wMc760+NN7~K(FCKsWzf*^O&(yDb<~`i2ATjaWtqr-;
zcQZc7?E9#?;6#6G`i~d<B};zi#Im&95MLkQ&CZc^#Q7Z~BLf4A1OqrMA))^WEi5^K
zVHqFq>*(ws90894P&B}z0J}C&6u`A1#~!j)?6D_-u2nA{XGA6^h$g2eBqe<C^$GjH
zAJ!4jz%)UESzSPyaig?A^AAynGYr8G6%I5oTeP*XIL;I`h<yR_EIS8x#{mmdU;?WE
zVo*YY_~H(l=XszBDJ?%ICAG*1?*IKr{)c!1U8f|P&gA^ug8bstBE78Q{5(){JODHT
zX3XkmK@3bw_Z+zsqN>fhbjzQbzgzyynQ}!*S#@2M9@x2TPq(|s0i6oM2<INb>s&*)
zb0=Up7d^*_qBz%3A0@y+84i(itoaTZ2)Ly8a(kQTY2Gbh$V+fN$+?4pHGIMMi;A}d
zH;DuVs5Vtj`Wn_%pDE+daO1;{_y!(@gT2OflWvH$tTQ{O*dpN6QJcK3<W8BiQ-`e4
zeE!yTCB@S7*{#ZwjbdMTnQz}1zd(8J3m@@am(HGbJ}qI_qb)7mW!M_A@OAilog?=P
z3ZDM_ZJ%iRpIfm`qWf{F%m+S}(|qg8UcYMl>h17he(UnQoQ2wV@9g5>*eL1`PU;LD
zxtoANhd-%<0s$q>LZTfJj)c>$0xl!a(lBz6QY{TbQX+byKuw8;`WPt@<Q7;8!Icu7
z;VJRjd~s&vlnAjjI0&`O7KElJ49h@4nD-V^dSF_%<cJd7qWZkz?NY!v1K|K~MkY~a
zT-5^)Pz4w`ymbW8km7~|URgkNBMKYjf{&L0p?gWA5mYx)^5=k89LSEqEF}@f{B^7Y
zma6cC6dD0>3CQR8j6inDU&pP;Mj(3#VGP1U$c32%iibX+8-tP#vHK0ZDC0pg@vUPu
z6C{8UMIyv|pt1}(ph2b}ms*lYrYvdPie?I0I^lp9kH{g0p0ZILrp1ixFi@t2I1H4u
zksSsq`m&J915p%*rJ$LDk`iFK7THngDFNBIzmAzKNGSmnjff%zJyl?jP6ZU#t-)m+
zTC}1%6k;+c^pG<zYJ}LcqJ|zuguqG(<e&uQdgN>>h~n5SP$Mynf|UUQ-mGk({K^Z2
L*MQ+J3+4d;JZ$R>

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/Fixtures/Zip/nojson.zip b/tests/Composer/Test/Util/Fixtures/Zip/nojson.zip
new file mode 100644
index 0000000000000000000000000000000000000000..e536b956ce1f7c30410c96e53079a7a272bee0d6
GIT binary patch
literal 134
zcmWIWW@h1H0D;-TDSluElwe^HU`Wf)*AI>0VYvOiCgvIte`OS52=HcP5@p7vhX-ba
d!&^rX6Ji1f+=KvcRyL40BM{mFX(JGa0RSi#7c&3=

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/Fixtures/Zip/root.zip b/tests/Composer/Test/Util/Fixtures/Zip/root.zip
new file mode 100644
index 0000000000000000000000000000000000000000..fd08f4d34dca94997e0a368500e9db6d9458ee46
GIT binary patch
literal 194
zcmWIWW@Zs#-~htlpcFp_B*4ocz>u7uTaaIzTBMg%oSzpO!NV~BZB0xb5PxM9VOaev
zh=FP8o+EccRJB=`ZuwL5cgYbY)pb#N3<2Kk9QAp{+ogcUfpCB~Ba<jI!Wv{bUIreR
er4CCPK}<ADIpCHCc(byB6fgpzJCIHVaTox^X)gu<

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/Fixtures/Zip/subfolder.zip b/tests/Composer/Test/Util/Fixtures/Zip/subfolder.zip
new file mode 100644
index 0000000000000000000000000000000000000000..93060bea23bf3efe8fec023cb6c2dd42ee44a80e
GIT binary patch
literal 1328
zcmWIWW@h1H0D<WdDSluElwe^HU??t4(hrT`VQ~FX6JrO&Ul~Oh0)RS17&w4%2AU3D
zs17}s;P~K@{GwEl*6uGgF%D3zZ)bSt9WoGT`_CDex>9<*fOmYO^o~FaN4*AxTAik*
z2{)dL%~_!BcW{<<ftbO+m(Gl#v8qcydtMViDwjT~^(`mE$!kv~HZbrkQjLi@xM8cu
z3lo<4&nu3ts*)A|T(xnJUHE&Bo%Rn{O|_<&fBJuI|BBBwVOKX_uH9UJU(W3C-Qa4U
zpO0rey*>YzU)LgyQ-2i#pKZKtBI5c|F|oE_%ktS7iS<s)<CApWX84<5JXFXz_fp%o
zEsJgMx)fg&5|clq9^WOtam(Vr>*FE=|M50!NPqi(^6jtqz$w;lm-d`6t`T9;Jrwua
zFSm-5p}cqtKcnZLNQ*=1`#}c0c612b^@t<Do1LR)QPbZ4zz}AUU;u|CB<yFSg(N31
zB;(_K9i9DyBj6DLiUe2$VAlqU0Jt{fxI@;8J?<pXwd%#=jK<^y(d6`mq=XN?K4BmD
z!#V;Qm?lUts|!doZj=^i{vqmch9UT&!hr^6i?$XP$C;uAu`fWLW#{1TIACE4^n3*n
zgOU-%7wE}|8=8#L@^eyBi{RdeB_c%n3l2g}u^>Nyd=1r@oS$2eUz}Q`msOmf2TR3y
zZy|xW`dJVI)6zXh?u4jnvo788r{?dHBTB04qV&KHt<NjoE(LTX2nTpGGKn(d$|F2L
z6=2}-))7QQLY)JiV<5T_VU8UCybK84OB#)!x{-pN1D<=39f6rx5XSs<tYKt8q=C=~
zh)Y26kIx8Xm;80yjBEt5hY-dfJcJyl5-1*ehi(i?lEUsc%(Q^;+gry<CP)CoQwGF$
rpp=0e&Y*OG9D}IN+JtHdS}K8<2udXZ-mGk(7-a{-A3(1tF@tyjEIM%5

literal 0
HcmV?d00001

diff --git a/tests/Composer/Test/Util/ZipTest.php b/tests/Composer/Test/Util/ZipTest.php
new file mode 100644
index 000000000..c47373274
--- /dev/null
+++ b/tests/Composer/Test/Util/ZipTest.php
@@ -0,0 +1,117 @@
+<?php
+
+/*
+ * This file is part of Composer.
+ *
+ * (c) Nils Adermann <naderman@naderman.de>
+ *     Jordi Boggiano <j.boggiano@seld.be>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Composer\Test\Util;
+
+use Composer\Util\Zip;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @author Andreas Schempp <andreas.schempp@terminal42.ch>
+ */
+class ZipTest extends TestCase
+{
+    public function testThrowsExceptionIfZipExcentionIsNotLoaded()
+    {
+        if (extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is loaded.');
+        }
+
+        $this->setExpectedException('\RuntimeException', 'The Zip Util requires PHP\'s zip extension');
+
+        Zip::getComposerJson('');
+    }
+
+    public function testReturnsNullifTheZipIsNotFound()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/invalid.zip');
+
+        $this->assertNull($result);
+    }
+
+    public function testReturnsNullIfTheZipIsEmpty()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/empty.zip');
+
+        $this->assertNull($result);
+    }
+
+    public function testReturnsNullIfTheZipHasNoComposerJson()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/nojson.zip');
+
+        $this->assertNull($result);
+    }
+
+    public function testReturnsNullIfTheComposerJsonIsInASubSubfolder()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/subfolder.zip');
+
+        $this->assertNull($result);
+    }
+
+    public function testReturnsComposerJsonInZipRoot()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/root.zip');
+
+        $this->assertEquals("{\n    \"name\": \"foo/bar\"\n}\n", $result);
+    }
+
+    public function testReturnsComposerJsonInFirstFolder()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/folder.zip');
+
+        $this->assertEquals("{\n    \"name\": \"foo/bar\"\n}\n", $result);
+    }
+
+    public function testReturnsRootComposerJsonAndSkipsSubfolders()
+    {
+        if (!extension_loaded('zip')) {
+            $this->markTestSkipped('The PHP zip extension is not loaded.');
+            return;
+        }
+
+        $result = Zip::getComposerJson(__DIR__.'/Fixtures/Zip/multiple.zip');
+
+        $this->assertEquals("{\n    \"name\": \"foo/bar\"\n}\n", $result);
+    }
+}